[libcxx-commits] [PATCH] D94921: [libc++] Make LIBCXX_ENABLE_FILESYSTEM fully consistent

Reid Kleckner via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 19 09:55:30 PST 2021


rnk added a comment.

Thanks!



================
Comment at: libcxx/include/filesystem:255
+#if defined(_LIBCPP_HAS_NO_FILESYSTEM_LIBRARY)
+# error "The Filesystem library is not supported by this configuration of libc++"
+#endif
----------------
What do you think of allowing users to feature test with `__has_include(<filesystem>)`? This could be implemented as part of the installation rules for include/*, but that adds some complexity, and it will not work when using libc++ from a build directory. It seems nice-to-have to me, but not super important.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94921/new/

https://reviews.llvm.org/D94921



More information about the libcxx-commits mailing list