[libcxx-commits] [PATCH] D91004: [libc++] Implements concept destructible

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM. Feel free to commit after fixing the minor comments.



================
Comment at: libcxx/test/std/concepts/concept.destructible/destructible.compile.pass.cpp:20
+
+struct Defaulted{ ~Defaulted() = default; };
+struct Deleted{ ~Deleted() = delete; };
----------------
We generally put a space before the opening brace of the struct. If only we had Clang-format :-).


================
Comment at: libcxx/test/std/concepts/concept.destructible/destructible.compile.pass.cpp:50
+
+    test<Noexcept>();
+    test<NoexceptTrue>();
----------------
We could also add tests for a few fundamental types like `int`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91004/new/

https://reviews.llvm.org/D91004