[libcxx-commits] [PATCH] D93912: [libc++][P1679] add string contains

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 19 07:41:46 PST 2021

Quuxplusone added a comment.

> https://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations seems out of date anyway, the draft standard is maybe a better source? https://eel.is/c++draft/version.syn

Good call. I had not thought to check https://eel.is/c++draft/version.syn when I did D93830 <https://reviews.llvm.org/D93830>. On the one hand version.syn is more authoritative; on the downside version.syn fails to mention what P-numbered papers each macro refers to, and also thus fails to include a "history" of how each macro should be set in each different language mode. I continue to think that at some point we'll need to rejigger `generate_feature_test_macro_components.py` to include P-numbered papers (e.g. `"p1679"`) in the big data table, as well as language modes (e.g. `"c++14"`).

I wonder if WG21 considers https://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations to be unmaintained/obsolete, now that version.syn is part of the formal standard.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list