[libcxx-commits] [PATCH] D94969: [libc++] Split re.alg tests into locale-dependent and independent tests

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 19 06:47:34 PST 2021


arichardson created this revision.
arichardson added reviewers: libc++, howard.hinnant, ldionne.
Herald added subscribers: krytarowski, emaste.
arichardson requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

Currently all these tests are XFAILED on Linux even though the problem
only seems to be with the few checks that look at collation. To retain
test coverage this splits the locale-dependent tests into a separate
.pass.cpp that is XFAILed as before.
This commit also XFAILs the locale-dependent tests on FreeBSD since the
[=M=] and [.ch.] behaviour for cs_CZ also doesn't seem to match the
behaviour that is expected by these tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94969

Files:
  libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.match/awk.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.match/basic.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.match/extended.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.search/awk.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.search/basic.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.search/ecma.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp
  libcxx/test/std/re/re.alg/re.alg.search/extended.pass.cpp
  libcxx/utils/libcxx/test/features.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94969.317548.patch
Type: text/x-patch
Size: 75332 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210119/1a34913f/attachment-0001.bin>


More information about the libcxx-commits mailing list