[libcxx-commits] [PATCH] D94953: [libc++] Use ioctl when available to get random_device entropy.

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 19 05:24:53 PST 2021


curdeius added inline comments.


================
Comment at: libcxx/src/random.cpp:180
 {
+#if defined(_LIBCPP_USING_DEV_RANDOM) && defined(RNDGETENTCNT)
+  int ent;
----------------
This could be guarded even more if we wanted. E.g. defining `_LIBCPP_USING_IOCTL/LINUX_RANDOM_H`, but personally I think that just checking for `RNDGETENTCNT` is enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94953/new/

https://reviews.llvm.org/D94953



More information about the libcxx-commits mailing list