[libcxx-commits] [PATCH] D94921: [libc++] Make LIBCXX_ENABLE_FILESYSTEM fully consistent

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 19 02:30:52 PST 2021


mstorsjo added a comment.

FWIW, +1 from me on this one. I've earlier run into cases where code checks for whether `<filesystem>` is available and works, where it has accidentally seemed to work as long as the test only used features provided entirely by the header. See e.g. https://codereview.qt-project.org/c/qt/qtbase/+/295469 for such a case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94921/new/

https://reviews.llvm.org/D94921



More information about the libcxx-commits mailing list