[libcxx-commits] [PATCH] D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit

Ruslan Arutyunyan via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 18 14:54:37 PST 2021

rarutyun added a comment.

In D92044#2505506 <https://reviews.llvm.org/D92044#2505506>, @ldionne wrote:

> In D92044#2505445 <https://reviews.llvm.org/D92044#2505445>, @rarutyun wrote:
>> In D92044#2505294 <https://reviews.llvm.org/D92044#2505294>, @ldionne wrote:
>>> Do you need help committing this?
>> I think so.
>> I would prefer to go through this path myself, to make commits directly (if it's possible and if I have enough permissions to do that). It's just may save the time of other people and your time in particular:) Currently, I just don't know what to do. So if you (or somebody else) can teach me it would be great.
>> But I don't mind if you merge it yourself. Please choose the way that works better for you.
> The steps to gain commit access are explained here: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. It's generally for people with a history of submitting patches already, so I'll let you judge whether you think it's right for you or not.
> In the meantime, I'm happy to apply your patch. Can you please provide `Author Name <email at domain>` so I can properly attribute the commit?

Ok. Currently I am planning to continue my contribution, so let me probably to request that access later after a couple of more commits.

Information for the commit: `Ruslan Arutyunyan ruslan.arutyunyan at intel.com`

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list