[libcxx-commits] [PATCH] D93912: [libc++][P1679] add string contains

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

Ok, I take it back. `__str_find` calls `Traits::find`, which is NOT always noexcept.  (It *is* for all the specializations of `std::char_traits`, but that's not enough). So we can't slap `NOEXCEPT` here; in fact, we should revisit `__str_find`, and remove some of the `NOEXCEPT`s that are already there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93912/new/

https://reviews.llvm.org/D93912