[libcxx-commits] [PATCH] D94499: [libc++] Rename check-cxx-deps to cxx-test-depends for consistency

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D94499#2493557 <https://reviews.llvm.org/D94499#2493557>, @dexonsmith wrote:

> LGTM!
>
> Can / should this be added to the catch-all `test-depends` as well? (I thought llvm-test-depends and clang-test-depends were both added there somewhere, although I admit I just the code and I don't see it...) Regardless, this could be done separately / later if it makes sense to do.

My preference would be not to do that. The reason is that we want to have different build requirements for libc++ and Clang or LLVM. For example, we want to move towards requiring a more recent compiler. Running the libc++ build (and/or tests) by default when setting up LLVM would make that more difficult.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94499/new/

https://reviews.llvm.org/D94499