[libcxx-commits] [PATCH] D74489: [libc++] Remove workarounds for the lack of clock_gettime on older macOS platforms

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 18 10:18:59 PST 2021


ldionne added a comment.

In D74489#2497044 <https://reviews.llvm.org/D74489#2497044>, @thakis wrote:

> We're looking into bumping libc++ in chromium, and this is a problem for us. We statically link libc++, and we still support 10.11. (We _just_ dropped support for 10.10 in our last release iirc.) What do you recommend as path forward?

Ugh, that's unfortunate. I see two options:

1. We revert the patch here, or
2. You carry a local patch until you don't support 10.11 anymore

The underlying question I'm really curious to hear the answer to is why don't you use the system `libc++.dylib`? How do you make sure that you don't have ODR issues when linking against macOS system frameworks that might be linking against `libc++.dylib`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74489/new/

https://reviews.llvm.org/D74489



More information about the libcxx-commits mailing list