[libcxx-commits] [PATCH] D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 18 09:37:51 PST 2021

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This is why i think that's okay (from the documentation you linked on Dec 9):

  Maximum number of bytes the implementation will store as a pathname in a user-supplied buffer of unspecified size, including the terminating null character. Minimum number the implementation will accept as the maximum number of bytes in a pathname.
  Minimum Acceptable Value: {_POSIX_PATH_MAX}

I still think it would be better to use `realpath` instead and bump your OS requirements (since we might want to drop the `PATH_MAX` codepath in libcxx eventually). But enough time has been wasted for such a small change.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list