[libcxx-commits] [PATCH] D94817: [MSVC] Don't add -nostdinc++ -isystem to runtimes builds

[Reid Kleckner via Phabricator via libcxx-commits]

rnk added inline comments.


================
Comment at: runtimes/CMakeLists.txt:81
+# Disable use of the installed C++ standard library when building runtimes.  If
+# the host compiler is MSVC or clang-cl, then the runtime compiler will be
+# clang-cl. clang-cl doesn't support -nostdinc++ or -isystem, so don't use them.
----------------
mstorsjo wrote:
> Doesn't the runtimes build system support cross compiling runtimes? (I don't use it myself as I need to build a number of other components between building the compiler and building the llvm provided runtimes, but afaik it's possible.) In that case, the logic for deducing things from the host compiler wouldn't apply...
You're right, this comment is incorrect, I think this CMakeLists.txt file is configured using the just-built clang. I had misunderstood how the runtimes build is put together. If we get here and MSVC is true, we must be using clang-cl, but the actual code change still makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94817/new/

https://reviews.llvm.org/D94817