[libcxx-commits] [PATCH] D94718: [libc++] Unbreak the debug mode

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/include/__config:888-895
 #if _LIBCPP_DEBUG_LEVEL >= 1
-# define _LIBCPP_DISABLE_EXTERN_TEMPLATE
+# define _LIBCPP_EXTERN_TEMPLATE(...)
 #endif
 
 #ifdef _LIBCPP_DISABLE_EXTERN_TEMPLATE
-#define _LIBCPP_EXTERN_TEMPLATE(...)
+# define _LIBCPP_EXTERN_TEMPLATE(...)
+# define _LIBCPP_EXTERN_TEMPLATE_EVEN_IN_DEBUG_MODE(...)
----------------
Isn't it possible that both `_LIBCPP_DEBUG_LEVEL >= 1` and `defined(_LIBCPP_DISABLE_EXTERN_TEMPLATE)` are true, and so `_LIBCPP_EXTERN_TEMPLATE` will be defined twice?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94718/new/

https://reviews.llvm.org/D94718