[libcxx-commits] [PATCH] D94718: [libc++] Unbreak the debug mode

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 14 13:43:17 PST 2021

ldionne created this revision.
ldionne added a reviewer: rnk.
Herald added a subscriber: jkorous.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

When the Debug mode is enabled, we disable extern declarations because we
don't want to use the functions compiled in the library, which might not
have had the debug mode enabled when built. However, some extern declarations
need to be kept, because code correctness depends on it.

31e820378b8a <https://reviews.llvm.org/rG31e820378b8ae4d81e9d206a7dae64ccf4b4c97f> removed those declarations, which had the unintended
consequence of breaking the debug build. This commit fixes that by
re-introducing a separate macro for the required extern declarations,
and adds a comment so that we don't fall into that trap in the future.

  rG LLVM Github Monorepo



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94718.316770.patch
Type: text/x-patch
Size: 13012 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210114/3b2edade/attachment-0001.bin>

More information about the libcxx-commits mailing list