[libcxx-commits] [PATCH] D75960: [libc++] Implement C++20's P0476r2: std::bit_cast

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/test/std/numerics/bit/bit.cast/bit_cast.pass.cpp:153
+        test_buffer_roundtrip(i);
+        test_intermediate_roundtrip<long>(i);
+        test_intermediate_roundtrip<double>(i);
----------------
Nit: you should probably use `long long` instead of `long` so that this test doesn't break on LLP64 data model (Windows). You might use uint64_t as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75960/new/

https://reviews.llvm.org/D75960