[libcxx-commits] [PATCH] D94591: [VE] Support VE in libunwind

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libunwind/src/Unwind-sjlj.c:41
+  // set by calling function before registering to be the landing pad
+  uintptr_t                       resumeLocation;
+
----------------
If you are guaranteed to require 64-bits, I think that it would be better to use `uint64_t` rather than `uintptr_t` which is pointer-width sized.  That is subtly different, even if in practice it means that it will be 64-bit currently.  Alternatively, changing the comment is entirely reasonable to do as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94591/new/

https://reviews.llvm.org/D94591