[libcxx-commits] [PATCH] D94530: [libc++] improve feature test macro script

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:1027
   table = [["Macro Name", "Value"]]
-  for std in get_std_dialects():
+  for std in get_std_dialects()[1:]:
     table += [["**" + std.replace("c++", "C++ ") + "**", ""]]
----------------
WimLeflere wrote:
> Quuxplusone wrote:
> > This `[1:]` smells questionable.
> If `c++11` is not skipped an empty table section will be generated for `c++11` as it has not macros
It seems to me like the correct thing to do here is to not include `c++11` in the dialects in the first place, then?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94530/new/

https://reviews.llvm.org/D94530