[libcxx-commits] [PATCH] D94530: [libc++] improve feature test macro script

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

The direction looks good to me too.

In D94530#2493796 <https://reviews.llvm.org/D94530#2493796>, @curdeius wrote:

> Concerning Python version, I don't know of any official policy but given that Python 3.5 is already end-of-life, requiring Python 3.6 seems OK.

Technically, LLVM decided to support Python 2.7 until January 2021 if I remember correctly. So I think we might be good.

But in all cases, this script is only run by libc++ contributors, and I think it's a more-than-reasonable requirement for that.



================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:708
 
+def get_std_nr(std):
+    return std.replace('c++', '')
----------------
I assume `nr` stands for `number`? I would find it a lot easier to read if you used `number` instead of trying to save a few characters (here and below).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94530/new/

https://reviews.llvm.org/D94530