[libcxx-commits] [PATCH] D93912: [libc++][P1679] add string contains

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.contains/contains.char.pass.cpp:42
+    // FIXME: wait for constexpr std::string P0980
+    // static_assert(test());
+
----------------
zoecarver wrote:
> I think we should leave this out. Whoever implements that can add tests as part of their patch. 
On further consideration, I think @zoecarver is right. Whoever implements [P0980] is going to have to adjust the tests for //all// `string` member functions (not just `contains`) — we'll need to constexprize the tests for `append` and `substr` and `operator[]` and so on and so forth. No specially greppable reminder ought to be needed in this //one// test, because it lives right alongside all the other tests that will need just as much auditing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93912/new/

https://reviews.llvm.org/D93912