[libcxx-commits] [PATCH] D90968: Fix for the Bug 41784

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver accepted this revision.
zoecarver added a comment.

This LGTM other than the small note.



================
Comment at: libcxx/include/atomic:1798
+
+    // delete explicitly in the most derived class to fix the Bug 41784
+    atomic& operator=(const atomic&) = delete;
----------------
Rather than saying "to fix the Bug..." do you mind saying something along the lines of Deleted explicitly in the most derived class to satisfy the requirement that atomic variables are not copyable. 


================
Comment at: libcxx/include/atomic:1799
+    // delete explicitly in the most derived class to fix the Bug 41784
+    atomic& operator=(const atomic&) = delete;
+    atomic& operator=(const atomic&) volatile = delete;
----------------
IIUC this line is a NFC? I think it makes sense to have these both here, just checking. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90968/new/

https://reviews.llvm.org/D90968