[libcxx-commits] [PATCH] D93819: [libc++] Implement [P0769] "Add shift to algorithm" (shift_left, shift_right)

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 11 14:56:46 PST 2021

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Can you also grab the tests from https://reviews.llvm.org/D60027? Generally speaking, while programmatic tests (like the two nested loops you used) are great because it gives us great coverage, however I try to strike a balance and also have at least some basic and really dumb test cases written entirely manually. This avoids the risk of a bug in the tests.

For some reason, that revision doesn't show up in the "Open Libc++ Reviews" query. I'll try to understand why and fix it.

Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.shift/shift_left.pass.cpp:32
+    for (int n = 0; n <= 15; ++n) {
+        for (int k=0; k <= n+2; ++k) {
+            std::copy(orig, orig+n, work);
`int k = 0;`

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list