[libcxx-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

Raul Tambre via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 11 10:03:12 PST 2021


tambre marked an inline comment as done.
tambre added inline comments.


================
Comment at: libcxx/utils/google-benchmark/CMakeLists.txt:3
-
-project (benchmark)
-
----------------
ldionne wrote:
> I don't think we want to change this. It's a third-party project (which is inconveniently checked-in as-is into our tree..).
Good catch. Did the same for `llvm/utils/benchmark/CMakeLists.txt`, though that one seems to have the `cmake_minimum_required(VERSION)` updated to 3.13.4 unlike this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94374/new/

https://reviews.llvm.org/D94374



More information about the libcxx-commits mailing list