[libcxx-commits] [PATCH] D93912: [libc++][P1679] add string contains

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.contains/contains.char.pass.cpp:21
+{
+    using S = std::string;
+
----------------
WimLeflere wrote:
> curdeius wrote:
> > curdeius wrote:
> > > You cannot just use std::string as it's not constexpr-friendly (yet), but need to use a constexpr-loving allocator or do some other hacks.
> > Actually, I think we just need to comment out constexpr test and add a FIXME note.
> I could add a `#ifdef __cpp_lib_constexpr_string` error message
Just add a FIXME comment that contains the exact string `P0980`. That way, anybody implementing [P0980 "Making std::string constexpr"](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p0980r1.pdf) will be able to find this FIXME comment, and fix it, as part of their grepping for `P0980`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93912/new/

https://reviews.llvm.org/D93912