[libcxx-commits] [PATCH] D94409: [libc++] [C++2b] [P1048] Add is_scoped_enum and is_scoped_enum_v.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I think we should update `libcxx/docs/Cxx2bStatusPaperStatus.csv`.



================
Comment at: libcxx/include/type_traits:4186
+#if _LIBCPP_STD_VER > 20
+
+template <class _Tp, bool = is_enum_v<_Tp> >
----------------
Pleas remove this newline, or add one before the `#endif`.


================
Comment at: libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_scoped_enum.pass.cpp:67
+
+typedef void (*FunctionPtr)();
+
----------------
Can you add a test for a function type (not a function pointer)? Also, for pointer to member function, pointer to data members and other fun things like that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94409/new/

https://reviews.llvm.org/D94409