[libcxx-commits] [PATCH] D91176: [20/N] [libcxx] Implement parsing of root_name for paths on windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 8 13:55:29 PST 2021


mstorsjo updated this revision to Diff 315506.
mstorsjo added a comment.

Renamed the `consumeSeparators` method to `consumeNSeparators` and added a comment pointing out that it consumes exactly that amount of separators. Removed unnecessary braces around single lines. (The `consumeSeparator` method can be renamed in a separate patch afterwards, I'd avoid doing it here to keep the diff as readable as possible.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91176/new/

https://reviews.llvm.org/D91176

Files:
  libcxx/src/filesystem/operations.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91176.315506.patch
Type: text/x-patch
Size: 4952 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210108/0c44bcf1/attachment.bin>


More information about the libcxx-commits mailing list