[libcxx-commits] [PATCH] D93186: [libc++abi] Simplify __gxx_personality_v0

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay added a subscriber: mstorsjo.
MaskRay added a comment.

In D93186#2485076 <https://reviews.llvm.org/D93186#2485076>, @ldionne wrote:

> So, just to clarify because I'm really not familiar with this code -- this is supposed to be a NFC change, right? My understanding so far is that this doesn't change functionality, but I'd like to confirm. Also, do you know someone else that knows this code and can give a good review?

Yes. Both this and D93190 <https://reviews.llvm.org/D93190> are NFC. `check-cxxabi` (`libcxxabi/test/*catch* libcxxabi/test/*except*`) is actually quite comprehensive.
The two main functions are mostly intact Howard after wrote them in 2012 (@mstorsjo has at least added the SEH part so may be familiar).
If it helps, I've written down the simplified version of `scan_eh_tab` and `__gxx_personality_v0` (what they should be like) in https://maskray.me/blog/2020-12-12-c++-exception-handling-abi


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93186/new/

https://reviews.llvm.org/D93186