[libcxx-commits] [PATCH] D93830: [libc++] Update generate_feature_test_macro_components.py to match SD-6

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 7 08:22:44 PST 2021


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Thanks a lot for the cleanup. However, since this touches the script in a major way, can we please avoid mixing the formatting changes and the actual changes? I would be more comfortable with this change if we started by changing `"` to `'` + sorted the macros without changing anything else, and then actually made the changes in this patch. That way, we'd be able to review the changes in `generate_feature_test_maro_components.py`. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93830/new/

https://reviews.llvm.org/D93830



More information about the libcxx-commits mailing list