[libcxx-commits] [PATCH] D91201: [libc++] LWG2070: Use Allocator construction for objects created with allocate_shared

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 6 14:46:55 PST 2021

ldionne added inline comments.

Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/libcxx.control_block_layout.pass.cpp:38
+struct OldEmplaceControlBlock
+  : std::__shared_weak_count
zoecarver wrote:
> Maybe this should be a `libcxx` test only? I see "libcxx" in the name, but maybe it should be moved to the "libcxx" test directory. 
It is a libc++ test only, since it has `// REQUIRES: libc++`. I've actually been thinking about not having separate directories for libcxx specific tests and other tests, since we have lit markup that can handle it.

I believe one of the reasons was to ease the life of MSVC and libstdc++ using our test suite, however they now run using lit and so they do have the features available.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list