[libcxx-commits] [PATCH] D93912: [libc++][P1679] add string contains

Wim Leflere via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 5 10:10:13 PST 2021


WimLeflere added a comment.

In D93912#2479707 <https://reviews.llvm.org/D93912#2479707>, @Mordante wrote:

> In D93912#2474869 <https://reviews.llvm.org/D93912#2474869>, @WimLeflere wrote:
>
>> Where are the feature test macros defined?
>> `__cpp_lib_string_contains` should be added
>
> The macro should be added to `libcxx/utils/generate_feature_test_macro_components.py`, then run the script to generate the proper macros and tests.

Thanks!
Should I check in the (changed) generated files?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93912/new/

https://reviews.llvm.org/D93912



More information about the libcxx-commits mailing list