[libcxx-commits] [PATCH] D97539: [libcxx] Implement semaphores for windows

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 26 08:21:31 PST 2021


curdeius requested changes to this revision.
curdeius added a comment.
This revision now requires changes to proceed.

LGTM apart from unnecessary `std::` (I wrote std:: without thinking too much before).



================
Comment at: libcxx/src/support/win32/thread_win32.cpp:308
+{
+  chrono::milliseconds __ms = std::chrono::ceil<chrono::milliseconds>(__ns);
+  return WaitForSingleObjectEx(*(PHANDLE)__sem, __ms.count(), false) ==
----------------
OK. Now, there's no need for `std::`. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97539/new/

https://reviews.llvm.org/D97539



More information about the libcxx-commits mailing list