[libcxx-commits] [PATCH] D97497: [libcxx] [test] Disable allocation checks in class.path tests on windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 26 06:16:59 PST 2021


mstorsjo added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.compare.pass.cpp:34-37
+#ifdef _WIN32
+#define DISABLE_NEW_COUNT
+#endif
+
----------------
curdeius wrote:
> `path::compare` should not allocate, nope?
> Or is it something else that may allocate in this test?
If D97551 is ok, I'll update this patch to drop the changes to this file here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97497/new/

https://reviews.llvm.org/D97497



More information about the libcxx-commits mailing list