[libcxx-commits] [PATCH] D97497: [libcxx] [test] Disable allocation checks in class.path tests on windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added a reviewer: libc++.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.

On windows, the path internal representation is wchar_t, and input/output often goes through utf8 inbetween, which causes extra allocations.

MS STL does the same, so this shouldn't be a standards compliance issue.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97497

Files:
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/source.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.compare.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.concat.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.generic.obs/generic_string_alloc.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.native.obs/string_alloc.pass.cpp


Index: libcxx/test/std/input.output/filesystems/class.path/path.member/path.native.obs/string_alloc.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/class.path/path.member/path.native.obs/string_alloc.pass.cpp
+++ libcxx/test/std/input.output/filesystems/class.path/path.member/path.native.obs/string_alloc.pass.cpp
@@ -25,6 +25,10 @@
 #include <type_traits>
 #include <cassert>
 
+#ifdef _WIN32
+#define DISABLE_NEW_COUNT
+#endif
+
 #include "test_macros.h"
 #include "test_iterators.h"
 #include "count_new.h"
Index: libcxx/test/std/input.output/filesystems/class.path/path.member/path.generic.obs/generic_string_alloc.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/class.path/path.member/path.generic.obs/generic_string_alloc.pass.cpp
+++ libcxx/test/std/input.output/filesystems/class.path/path.member/path.generic.obs/generic_string_alloc.pass.cpp
@@ -24,6 +24,10 @@
 #include <type_traits>
 #include <cassert>
 
+#ifdef _WIN32
+#define DISABLE_NEW_COUNT
+#endif
+
 #include "test_macros.h"
 #include "test_iterators.h"
 #include "count_new.h"
Index: libcxx/test/std/input.output/filesystems/class.path/path.member/path.concat.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/class.path/path.member/path.concat.pass.cpp
+++ libcxx/test/std/input.output/filesystems/class.path/path.member/path.concat.pass.cpp
@@ -36,6 +36,10 @@
 #include <string_view>
 #include <cassert>
 
+#ifdef _WIN32
+#define DISABLE_NEW_COUNT
+#endif
+
 #include "test_macros.h"
 #include "test_iterators.h"
 #include "count_new.h"
Index: libcxx/test/std/input.output/filesystems/class.path/path.member/path.compare.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/class.path/path.member/path.compare.pass.cpp
+++ libcxx/test/std/input.output/filesystems/class.path/path.member/path.compare.pass.cpp
@@ -31,6 +31,10 @@
 #include <vector>
 #include <cassert>
 
+#ifdef _WIN32
+#define DISABLE_NEW_COUNT
+#endif
+
 #include "test_macros.h"
 #include "test_iterators.h"
 #include "count_new.h"
Index: libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/source.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/source.pass.cpp
+++ libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/source.pass.cpp
@@ -29,6 +29,10 @@
 #include <string_view>
 #include <cassert>
 
+#ifdef _WIN32
+#define DISABLE_NEW_COUNT
+#endif
+
 #include "test_macros.h"
 #include "test_iterators.h"
 #include "count_new.h"
Index: libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp
+++ libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp
@@ -29,6 +29,10 @@
 #include <string_view>
 #include <cassert>
 
+#ifdef _WIN32
+#define DISABLE_NEW_COUNT
+#endif
+
 #include "test_macros.h"
 #include "test_iterators.h"
 #include "count_new.h"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97497.326486.patch
Type: text/x-patch
Size: 3352 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210225/aae10804/attachment-0001.bin>