[libcxx-commits] [PATCH] D97168: [libcxx] Don't use dllimport for a static member in a template

Thu Feb 25 11:30:56 PST 2021

mstorsjo added inline comments.

================
Comment at: libcxx/include/__config:673

+#ifndef _LIBCPP_DATA_VIS
+#  if !defined(_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS)
----------------
ldionne wrote:
> Maybe this can just be called `_LIBCPP_DEFAULT_VISIBILITY`?
> 
> And we could maybe also reuse this macro in the various `_LIBCPP_FUNC_VIS` & other macros (as a separate patch, I can try to clean this up).
Hmm, not entirely sure, that changes the semantics a bit: Currently the attributes say what they're supposed to annotate (function visibility, type visibility, etc), but that'd make it say what it does (on one platform) - which actually isn't the same across all platforms (the point here being we expressly want a different visibility for windows targets, for static members in a template, contrary to the other cases).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97168/new/

https://reviews.llvm.org/D97168