[libcxx-commits] [PATCH] D97365: [libc++] [C++2b] [P1682] Add to_underlying.

Thu Feb 25 10:10:06 PST 2021

Mordante added inline comments.

================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:599
+    "name": "__cpp_lib_to_underlying",
+    "values": { "c++2b": 202102 },
+    "headers": ["utility"],
----------------
Mordante wrote:
> curdeius wrote:
> > curdeius wrote:
> > > Mordante wrote:
> > > > The paper has no number. Is it certain this will be the final value?
> > > I'll wait for the draft to be updated before committing I think to confirm the value.
> > I'm pretty sure it will be the final value, since another feature approved in the same meeting uses this value. Cf. https://github.com/cplusplus/draft/pull/4515/files#diff-f46371f476893d323cfcb1383e9a70f07ff1c1f0c217e22294d0bf937aae6794R696.
> Sounds good enough to me. If it's wrong it's also trivial to fix.
I see there's a PR for this paper using `202102L` so this looks good. https://github.com/cplusplus/draft/pull/4526/commits/47fd349eef8e4bdf5cdaed9513505f903d5e8f38

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97365/new/

https://reviews.llvm.org/D97365