[libcxx-commits] [PATCH] D97456: [libcxx] [test] Fix the get_temp_file_name() function for mingw

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 25 04:49:00 PST 2021


mstorsjo added inline comments.


================
Comment at: libcxx/test/support/platform_support.h:59
 #include <string>
 #if defined(_WIN32) || defined(__MINGW32__)
+#   define WIN32_LEAN_AND_MEAN // Reduce overhead of including windows.h
----------------
The `defined(__MINGW32__)` here is redundant; `_WIN32` is defined in mingw configurations too, will amend the patch to simplify that while touching these lines.


================
Comment at: libcxx/test/support/platform_support.h:60
 #if defined(_WIN32) || defined(__MINGW32__)
+#   define WIN32_LEAN_AND_MEAN // Reduce overhead of including windows.h
 #   include <io.h> // _mktemp_s
----------------
curdeius wrote:
> Would defining `VC_EXTRALEAN` as well be beneficial and possible?
That one only seems to have an effect on ATL/MFC headers (I think), which we don't use here. (I hadn't ever heard of that one before actually.) On a MSVC 2019 installation (without ATL/MFC) I get no hits in the headers when grepping for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97456/new/

https://reviews.llvm.org/D97456



More information about the libcxx-commits mailing list