[libcxx-commits] [PATCH] D89943: [libcxx] [test] Fix path.decompose for windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 25 04:24:56 PST 2021


mstorsjo added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.decompose/path.decompose.pass.cpp:188
+        else
+          assert(p.is_absolute() == false);
+      }
----------------
Also I know one could write this condition like `assert(p.is_absolute() == (root_name[0] == '/' && root_name[1] == '/'));`, but I find such code less readable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89943/new/

https://reviews.llvm.org/D89943



More information about the libcxx-commits mailing list