[libcxx-commits] [PATCH] D97458: [libcxx] [test] Use string().c_str() to convert a std::filesystem::path to a const char*

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added a reviewer: libc++.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.

On Windows, path::value_type is wchar_t, so one can't pass the return value of path::c_str() directly to std::remove().

This matches what was done for tests under std/input.output/filesystems in 81db3c31aafec72f1cfec2a9da4381ece7f97a29 <https://reviews.llvm.org/rG81db3c31aafec72f1cfec2a9da4381ece7f97a29> and 3784bdf2176f38cc30134fab776efb43506c0c54 <https://reviews.llvm.org/rG3784bdf2176f38cc30134fab776efb43506c0c54>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97458

Files:
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.members/open_path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.cons/path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.members/open_path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.cons/path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.members/open_path.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97458.326339.patch
Type: text/x-patch
Size: 3429 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210225/1851e99c/attachment.bin>