[libcxx-commits] [PATCH] D97365: [libc++] [C++2b] [P1682] Add to_underlying.

Thu Feb 25 01:21:27 PST 2021

curdeius marked 4 inline comments as done.
curdeius added inline comments.

================
Comment at: libcxx/include/utility:1631

+#if _LIBCPP_STD_VER > 20
+template <class _Tp>
----------------
Mordante wrote:
> Would it be possible to make it available for earlier versions? I like to use this in D97115? I'm aware we're reluctant to offer features to earlier versions.
Would this be OK?

================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:599
+    "name": "__cpp_lib_to_underlying",
+    "values": { "c++2b": 202102 },
+    "headers": ["utility"],
----------------
curdeius wrote:
> Mordante wrote:
> > The paper has no number. Is it certain this will be the final value?
> I'll wait for the draft to be updated before committing I think to confirm the value.
I'm pretty sure it will be the final value, since another feature approved in the same meeting uses this value. Cf. https://github.com/cplusplus/draft/pull/4515/files#diff-f46371f476893d323cfcb1383e9a70f07ff1c1f0c217e22294d0bf937aae6794R696.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97365/new/

https://reviews.llvm.org/D97365