[libcxx-commits] [PATCH] D97359: [libcxx] adds concept std::movable

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Some small issues, but like to see the build pass before approving.



================
Comment at: libcxx/test/std/concepts/object/movable.compile.pass.cpp:12
+
+// template<class From, class To>
+// concept movable = see below;
----------------
Please remove `class From, `.


================
Comment at: libcxx/test/std/concepts/object/movable.compile.pass.cpp:21
+#include <map>
+#include <mutex>
+#include <optional>
----------------
I see the single thread build node is failing. Can you guard the usage of types defined in this header to be excluded if libc++ is build without thread support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97359/new/

https://reviews.llvm.org/D97359