[libcxx-commits] [libcxx] 4814985 - [libc++] NFC: Fix a few tests in pair that would succeed trivially

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 24 08:25:42 PST 2021


Author: Louis Dionne
Date: 2021-02-24T11:25:45-05:00
New Revision: 4814985dec576a71ae9eabec40e8ca20111f830c

URL: https://github.com/llvm/llvm-project/commit/4814985dec576a71ae9eabec40e8ca20111f830c
DIFF: https://github.com/llvm/llvm-project/commit/4814985dec576a71ae9eabec40e8ca20111f830c.diff

LOG: [libc++] NFC: Fix a few tests in pair that would succeed trivially

Added: 
    

Modified: 
    libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair.pass.cpp
    libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair_U_V.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair.pass.cpp b/libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair.pass.cpp
index 7dbf98f01723..0172692c895e 100644
--- a/libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair.pass.cpp
+++ b/libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair.pass.cpp
@@ -91,7 +91,7 @@ TEST_CONSTEXPR_CXX20 bool test() {
   {
     using T = std::pair<int, NotAssignable>;
     using P = std::pair<int, NotAssignable>;
-    static_assert(!std::is_assignable<T, P&&>::value, "");
+    static_assert(!std::is_assignable<T&, P&&>::value, "");
   }
   return true;
 }

diff  --git a/libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair_U_V.pass.cpp b/libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair_U_V.pass.cpp
index cd0c39a0bb6c..4e58e0b9ea10 100644
--- a/libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair_U_V.pass.cpp
+++ b/libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair_U_V.pass.cpp
@@ -68,8 +68,8 @@ TEST_CONSTEXPR_CXX20 bool test() {
   { // test const requirement
     using T = std::pair<CopyAssignableInt, CopyAssignableInt>;
     using P = std::pair<int, int>;
-    static_assert(!std::is_assignable<T, P&&>::value, "");
-    static_assert(!std::is_assignable<P, T&&>::value, "");
+    static_assert(!std::is_assignable<T&, P&&>::value, "");
+    static_assert(!std::is_assignable<P&, T&&>::value, "");
   }
   return true;
 }


        


More information about the libcxx-commits mailing list