[libcxx-commits] [PATCH] D97283: [libcxx][type_traits] is_unsigned is false for enum types

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Why doesn't `is_signed` be updated in the same way? I see the builds on buildkite passing, but the difference between `is_unsigned` and `is_signed` look very odd to me.



================
Comment at: libcxx/include/type_traits:1451
 
-#if __has_keyword(__is_unsigned)
+#if __has_keyword(__is_unsigned) && __has_keyword(__is_enum)
 
----------------
Please update the comments of the `#else` and `#endif`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97283/new/

https://reviews.llvm.org/D97283