[libcxx-commits] [PATCH] D97283: [libcxx][type_traits] is_unsigned is false for enum types
Tomas Matheson via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Feb 23 06:31:39 PST 2021
tmatheson created this revision.
tmatheson requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.
Enum types are not arithmetic, therefore both is_arithmetic and is_unsigned
should be false for them. This change fixes the implementation of is_unsigned
(which was returning true for enums) and adds some more tests. Also adds a test
for enum class to is_arithmetic.
Note that std::is_unsigned is based on the implementation of __is_unsigned,
which returns true for enum types. To avoid introducing version differences
between libcxx and clang, the implementation of __is_unsigned is left unchanged
here, and an explicit check for __is_enum is added to the implementation of
clang-format to pass the linter.
rG LLVM Github Monorepo
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4100 bytes
Desc: not available
More information about the libcxx-commits