[libcxx-commits] [PATCH] D97166: [libcxx] [docs] Update docs about how to build for Windows

Mon Feb 22 14:34:16 PST 2021

mstorsjo added inline comments.

================
Comment at: libcxx/docs/BuildingLibcxx.rst:104
+however running the tests require being run in an environment with a bash
+shell available, which can be provided e.g. by the MSYS2 project.
+
----------------
compnerd wrote:
> I believe that the documentation suggestions GNUWin32 for the tools, it would be nice to suggest that for consistency.
GNUWin32 doesn't supply e.g. bash, and afaik @rnk and others have moved away from setups using only that (and that it isn't enough here). In particular here, running things in a plain cmd shell doesn't work - right now. (It might work after more fixes somewhere, but I'm trying to get the shortest path towards a documented working configuration.)

================
Comment at: libcxx/docs/BuildingLibcxx.rst:110
+path. From there, launch an MSYS2 shell via e.g.
+`\msys64\msys2_shell.cmd -full-path -mingw64` (preserving the earlier
+environment, allowing the MSVC headers/libraries and clang-cl to be found).
----------------
compnerd wrote:
> I think it would be better to just use `path %PATH%;%ProgramFiles%\Git\usr\bin` as git is also provided by MSVC, and is going to be needed to clone the projects, so it avoids an additional dependency.
Hmm, maybe, that's worth a try. That would at least provide bash, but it remains to see if it hooks that up the right way, with all the interactions between python/llvm-lit and everything.

================
Comment at: libcxx/docs/BuildingLibcxx.rst:128
+`-DLIBCXX_TARGET_TRIPLE=x86_64-windows-msvc` to the cmake configuration
+in this case.)
+
----------------
compnerd wrote:
> This would not be needed with the suggestion above right?
If not using a MSYS2 shell, then no, this one wouldn't be needed no.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97166/new/

https://reviews.llvm.org/D97166