[libcxx-commits] [PATCH] D97166: [libcxx] [docs] Update docs about how to build for Windows

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd added inline comments.


================
Comment at: libcxx/docs/BuildingLibcxx.rst:104
+however running the tests require being run in an environment with a bash
+shell available, which can be provided e.g. by the MSYS2 project.
+
----------------
I believe that the documentation suggestions GNUWin32 for the tools, it would be nice to suggest that for consistency.


================
Comment at: libcxx/docs/BuildingLibcxx.rst:110
+path. From there, launch an MSYS2 shell via e.g.
+`\msys64\msys2_shell.cmd -full-path -mingw64` (preserving the earlier
+environment, allowing the MSVC headers/libraries and clang-cl to be found).
----------------
I think it would be better to just use `path %PATH%;%ProgramFiles%\Git\usr\bin` as git is also provided by MSVC, and is going to be needed to clone the projects, so it avoids an additional dependency.


================
Comment at: libcxx/docs/BuildingLibcxx.rst:128
+`-DLIBCXX_TARGET_TRIPLE=x86_64-windows-msvc` to the cmake configuration
+in this case.)
+
----------------
This would not be needed with the suggestion above right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97166/new/

https://reviews.llvm.org/D97166