[libcxx-commits] [PATCH] D96657: [libcxx] adds common_reference to <type_traits>

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/include/type_traits:2471
+
+//            COMMON-REF(A, B) is COND-RES(COPYCV(X, Y) &, COPYCV(​Y, X) &)
+//            if that type exists and is a reference type.
----------------
miscco wrote:
> I think it would not hurt to add the standardese for X and Y too
Good point!


================
Comment at: libcxx/include/type_traits:2492
+
+//            Otherwise, let C be remove_­reference_­t<COMMON-REF(X&, Y&)>&&. If A and B are both
+//            rvalue reference types, C is well-formed, and ...
----------------
miscco wrote:
> Is there a reason for the deep identation?
This was copied from D74351. If you don't remember why, I'll delete it (and all the others too?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96657/new/

https://reviews.llvm.org/D96657