[libcxx-commits] [PATCH] D96657: [libcxx] adds common_reference to <type_traits>
Christopher Di Bella via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Feb 21 22:55:10 PST 2021
cjdb added inline comments.
Comment at: libcxx/include/type_traits:2471
+// COMMON-REF(A, B) is COND-RES(COPYCV(X, Y) &, COPYCV(Y, X) &)
+// if that type exists and is a reference type.
> I think it would not hurt to add the standardese for X and Y too
Comment at: libcxx/include/type_traits:2492
+// Otherwise, let C be remove_reference_t<COMMON-REF(X&, Y&)>&&. If A and B are both
+// rvalue reference types, C is well-formed, and ...
> Is there a reason for the deep identation?
This was copied from D74351. If you don't remember why, I'll delete it (and all the others too?).
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits