[libcxx-commits] [PATCH] D97167: [libcxx] [test] Don't pass INCLUDE to clang via -isystem

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added reviewers: libc++, CaseyCarter, STL_MSFT, miscco.
Herald added a subscriber: arichardson.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.

Passing the MSVC include dirs via `-isystem` makes them included before clang's own include resource dir (`<prefix>/lib/clang/<version>/include`). This causes includes of `stddef.h` to bypass clang's `stddef.h` which defines `max_align_t`, which libc++ needs defined.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97167

Files:
  libcxx/utils/libcxx/test/config.py


Index: libcxx/utils/libcxx/test/config.py
===================================================================
--- libcxx/utils/libcxx/test/config.py
+++ libcxx/utils/libcxx/test/config.py
@@ -204,7 +204,7 @@
 
         assert self.cxx_is_clang_cl
         flags = []
-        compile_flags = _prefixed_env_list('INCLUDE', '-isystem')
+        compile_flags = []
         link_flags = _prefixed_env_list('LIB', '-L')
         for path in _split_env_var('LIB'):
             self.add_path(self.exec_env, path)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97167.325347.patch
Type: text/x-patch
Size: 508 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210221/5eda35fd/attachment.bin>