[libcxx-commits] [PATCH] D62641: Support arrays in make_shared and allocate_shared (P0674R1)
Zoe Carver via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Feb 21 12:21:15 PST 2021
zoecarver marked 4 inline comments as done.
zoecarver added inline comments.
================
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/create_array.pass.cpp:47
+ A(const A&) : value(++count) {}
+ ~A() { assert(count-- == value); }
+};
----------------
ldionne wrote:
> zoecarver wrote:
> > This should help make sure we destroy things in the correct order.
> Can you add a comment mentioning that? It's clever.
Done. Thanks :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62641/new/
https://reviews.llvm.org/D62641
More information about the libcxx-commits
mailing list