[libcxx-commits] [libcxx] 3d6ca4b - [libcxx] [test] Call create_directory_symlink when linking directories
Martin Storsjö via libcxx-commits
libcxx-commits at lists.llvm.org
Sat Feb 20 14:26:03 PST 2021
Author: Martin Storsjö
Date: 2021-02-21T00:25:54+02:00
New Revision: 3d6ca4b8dcee38ce2053fdddaa9576e5aa978bdf
URL: https://github.com/llvm/llvm-project/commit/3d6ca4b8dcee38ce2053fdddaa9576e5aa978bdf
DIFF: https://github.com/llvm/llvm-project/commit/3d6ca4b8dcee38ce2053fdddaa9576e5aa978bdf.diff
LOG: [libcxx] [test] Call create_directory_symlink when linking directories
This makes the symlinks work properly on windows.
A similar round of cleanup was done in
c41bda7f5fc26e4602a029646991d6a5c59cb365, but these tests were
added after that.
Differential Revision: https://reviews.llvm.org/D97089
Added:
Modified:
libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp
libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory_with_attributes.pass.cpp
Removed:
################################################################################
diff --git a/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp b/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp
index b5b1a8cca198..30dea6140588 100644
--- a/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp
+++ b/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp
@@ -118,7 +118,7 @@ TEST_CASE(dest_is_symlink_to_dir)
{
scoped_test_env env;
const path dir = env.create_dir("dir");
- const path sym = env.create_symlink(dir, "sym_name");
+ const path sym = env.create_directory_symlink(dir, "sym_name");
std::error_code ec = GetTestEC();
TEST_CHECK(create_directory(sym, ec) == false);
TEST_CHECK(!ec);
diff --git a/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory_with_attributes.pass.cpp b/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory_with_attributes.pass.cpp
index 83f9c8d27444..cd436d9c6fb1 100644
--- a/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory_with_attributes.pass.cpp
+++ b/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory_with_attributes.pass.cpp
@@ -147,7 +147,7 @@ TEST_CASE(dest_is_symlink_to_unexisting) {
TEST_CASE(dest_is_symlink_to_dir) {
scoped_test_env env;
const path dir = env.create_dir("dir");
- const path sym = env.create_symlink(dir, "sym_name");
+ const path sym = env.create_directory_symlink(dir, "sym_name");
const path attr_dir = env.create_dir("attr_dir");
{
std::error_code ec = GetTestEC();
More information about the libcxx-commits
mailing list