[libcxx-commits] [PATCH] D97089: [libcxx] [test] Call create_directory_symlink when linking directories

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 19 14:23:13 PST 2021


mstorsjo created this revision.
mstorsjo added reviewers: curdeius, ldionne, libc++.
Herald added a subscriber: jdoerfert.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.

This makes the symlinks work properly on windows.

A similar round of cleanup was done in c41bda7f5fc26e4602a029646991d6a5c59cb365 <https://reviews.llvm.org/rGc41bda7f5fc26e4602a029646991d6a5c59cb365>, but these tests were added after that.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97089

Files:
  libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp
  libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory_with_attributes.pass.cpp


Index: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory_with_attributes.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory_with_attributes.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory_with_attributes.pass.cpp
@@ -152,7 +152,7 @@
 TEST_CASE(dest_is_symlink_to_dir) {
   scoped_test_env env;
   const path dir = env.create_dir("dir");
-  const path sym = env.create_symlink(dir, "sym_name");
+  const path sym = env.create_directory_symlink(dir, "sym_name");
   const path attr_dir = env.create_dir("attr_dir");
   {
     std::error_code ec = GetTestEC();
Index: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp
@@ -122,7 +122,7 @@
 {
     scoped_test_env env;
     const path dir = env.create_dir("dir");
-    const path sym = env.create_symlink(dir, "sym_name");
+    const path sym = env.create_directory_symlink(dir, "sym_name");
     std::error_code ec = GetTestEC();
     TEST_CHECK(create_directory(sym, ec) == false);
 #ifndef _WIN32


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97089.325088.patch
Type: text/x-patch
Size: 1501 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210219/357cd505/attachment.bin>


More information about the libcxx-commits mailing list