[libcxx-commits] [PATCH] D96742: [libcxx] adds concept `std::assignable_from`

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 19 14:17:48 PST 2021

cjdb marked an inline comment as done.
cjdb added a comment.

In D96742#2575630 <https://reviews.llvm.org/D96742#2575630>, @ldionne wrote:

> The implementation matches the spec closely. I didn't look at the tests in careful detail, however as a general high-level comment: is there value in testing these concepts on a few common types like `std::string`, `std::vector`, etc. just to make sure they behave as we'd expect them?
> Those are the first types that users are going to use concepts with, so I tend to see value in making sure they work as expected (not that I see any reason they wouldn't, but catching bad surprises is the whole point). Basically, it's as if we had a few compilable examples of how to use the Standard Library.

Agreed. I'll add a few for `vector<int>` and `string`. Any other commonly used types that we should care about (e.g. `map`) or are `vector` and `string` "good enough"?

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list